Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only mock consola in production #2110

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: only mock consola in production #2110

merged 2 commits into from
Jan 23, 2024

Conversation

cany748
Copy link
Contributor

@cany748 cany748 commented Jan 23, 2024

🔗 Linked issue

#1991

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #1991

This change uses the full build consola in development mode. It might be confusing if the behavior in development mode and production mode is different, maybe it would be worth writing about this in the documentation?

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

pi0
pi0 reviewed Jan 23, 2024
View reviewed changes
src/rollup/config.ts Outdated Show resolved Hide resolved
src/rollup/config.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat: only mock consola in production fix: only mock consola in production Jan 23, 2024
pi0
pi0 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit f9a3fce into nitrojs:main Jan 23, 2024
3 of 4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use full build of consola for development time
2 participants
@cany748 @pi0